-
Notifications
You must be signed in to change notification settings - Fork 74
DLFS - A filesystem built on replicated logs #43
Conversation
gerritsundaram
commented
Nov 2, 2016
- implement the hadoop FileSystem api
- implement the hadoop FileSystem api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The layout looks good to me. The initial code change looks good too. I think the major piece missing here is more about the metadata management or how to connect the stream namespace to filesystem namespace.
I like the discussion about stream storage primitives. I think you should drive the discussion there and finalize the stream storage primitives in DL. After that, it might be easier for an FileSystem implementation here.
@gerritsundaram any updates? |
long blockSize, | ||
Progressable progressable) throws IOException { | ||
|
||
// TODO: support overwrite, support permission |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we open a github issue for this?
|
||
@Override | ||
public void write(byte[] b, int off, int len) throws IOException { | ||
// TODO: improve AppendOnlyStreamWriter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we open a github issue for this "todo"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thanks for this.
Close this since it is overtaken by #227. marked it as duplicated. |
Descriptions of the changes in this PR: - FileSystem API wrapper built over dlog API (This is based on initial implementation from gerritsundaram at #43) Features supported: - create and append files - open files for reading - input stream and output stream for reading and writing data - list files - get file status - rename - mkdir Features aren't supported: - truncate - currently there is no clear distinguish between file and dir - only support delete recursive (This change includes small changes for #224 #225 #226 ). Author: Sijie Guo <sijie@apache.org> Reviewers: Jia Zhai <None> This closes #227 from sijie/fix_create_log